altTab: Avoid setting GObject property to undefined instead of null

The windowActor in the CyclerHighlight was set to undefined if
this._window was null. This was causing an error when trying to set it
as a property.

Fixes https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/4167

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1820>

diff --git a/js/ui/altTab.js b/js/ui/altTab.js
index 3ecadad86861fb02905784b14343548c85657a10..2ae7b6b23230b7f87015ca56ca82eb19d460b647 100644 (file)
--- a/js/ui/altTab.js
+++ b/js/ui/altTab.js
@@ -427,7 +427,7 @@ class CyclerHighlight extends St.Widget {
         if (this._clone.source)
             this._clone.source.sync_visibility();
 
-        const windowActor = this._window?.get_compositor_private();
+        const windowActor = this._window?.get_compositor_private() ?? null;
 
         if (windowActor)
             windowActor.hide();